Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilterQuality property on SKPaint #49

Merged
merged 1 commit into from
Apr 8, 2016
Merged

Add FilterQuality property on SKPaint #49

merged 1 commit into from
Apr 8, 2016

Conversation

petergolde
Copy link
Contributor

Requires PR #4 for mono/skia.

@petergolde
Copy link
Contributor Author

I am happy to add documentation also, but I am not familiar with the tools to do so. If you point me to documentation on how to update the documentation I can amend this PR.

@bholmes
Copy link
Contributor

bholmes commented Apr 6, 2016

@petergolde,

Yes adding docs would be a great help! We need to write up some instructions in the README.

For now what I have been doing is running in bash

sh bootstrapper.sh -t docs

This will modify the docs directory, adding stubs for the classes and members that were added. The problem that I have is that a bunch of whitespace diffs are introduced when I run this as well. (I need to get with miguel to see why that is.) I revert the changes I do not want, then fill in the new stubbed out doc entries.

To verify my changes I then run...

mdoc-export-html -o bill docs/en/

The output from this is not perfect either, but will give you a set of html pages to view and review your new changes. Finally commit the changes to the docs folder.

Make sense?

@bholmes bholmes self-assigned this Apr 8, 2016
@bholmes bholmes merged commit d26b9d6 into mono:master Apr 8, 2016
bholmes added a commit that referenced this pull request Apr 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants